Skip to content

feat(networksecurity): add org-level support to google_network_security_address_groups datasource#17170

Open
d-costa wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
d-costa:f-network-security-address-groups-org-datasource
Open

feat(networksecurity): add org-level support to google_network_security_address_groups datasource#17170
d-costa wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
d-costa:f-network-security-address-groups-org-datasource

Conversation

@d-costa
Copy link
Copy Markdown

@d-costa d-costa commented Apr 17, 2026

Add optional 'parent' field to the google_network_security_address_groups data source, enabling listing of address groups at the organization level (e.g. parent = "organizations/123456789") in addition to the existing project-level support.

  • Add parent field (Optional) which is mutually exclusive with project
  • Setting parent takes precedence, falling through to project-level path for backward compatibility
  • Add test for organization-level listing
  • Update documentation with org-level example and field descriptions

networksecurity: added `parent` field to `google_network_security_address_groups` data source

…ty_address_groups datasource

Add optional 'parent' field to the google_network_security_address_groups
data source, enabling listing of address groups at the organization level
(e.g. parent = "organizations/123456789") in addition to the existing
project-level support.

- Add 'parent' field (Optional) with ConflictsWith 'project'
- Add ConflictsWith 'parent' to existing 'project' field
- When 'parent' is set, URL uses the parent path directly, supporting
  both 'organizations/{id}' and 'projects/{id}' prefixes
- When 'parent' is absent, falls through to the unchanged project-level
  code path for full backward compatibility
- Add acceptance test for organization-level listing
- Update documentation with org-level example and field descriptions
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 17, 2026
@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@malhotrasagar2212, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@d-costa
Copy link
Copy Markdown
Author

d-costa commented Apr 17, 2026

(I did not find an open issue for this feature)

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 17, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 104 insertions(+), 15 deletions(-))
google-beta provider: Diff ( 3 files changed, 104 insertions(+), 15 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 82
Passed tests: 74
Skipped tests: 7
Affected tests: 1

Click here to see the affected service packages
  • networksecurity

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataSourceNetworkSecurityAddressGroups_organization

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataSourceNetworkSecurityAddressGroups_organization [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants